> The point is not really to limit the amount of nodes, but rather to limit how > fast they come. > > As suggested on JBS, I've made `make_scalar_in_safepoints` able to process a > single safepoint, and `SafePointNode::Ideal` is just taking care of itself. I > have added an overload for compatibility. The name is a bit awkward, > especially the plural, since if the new last argument is provided, it doesn't > work on multiple safepoints. Yet it does the same, and we can argue it still > works on all the safepoints contained in a singleton set. Besides, > `make_scalar_in_safepoint` exists, and is a helper of > `make_scalar_in_safepoints`, so I'd rather not mess with names too much. > Similar semantics get the same name. > > Conceptually, it also sounds nicer to me that idealizing a safepoint is not > touching all the other cousin safepoints at the same time. > > Thanks, > Marc > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai).
Marc Chevalier has updated the pull request incrementally with one additional commit since the last revision: Comment ------------- Changes: - all: https://git.openjdk.org/valhalla/pull/2480/files - new: https://git.openjdk.org/valhalla/pull/2480/files/a7c2c156..b5b6cb87 Webrevs: - full: https://webrevs.openjdk.org/?repo=valhalla&pr=2480&range=01 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=2480&range=00-01 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/valhalla/pull/2480.diff Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2480/head:pull/2480 PR: https://git.openjdk.org/valhalla/pull/2480
