On Thu, 28 May 2026 06:36:09 GMT, Stefan Karlsson <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update src/hotspot/share/oops/fieldStreams.hpp >> >> Co-authored-by: Dean Long <[email protected]> > > src/hotspot/share/oops/instanceKlass.cpp line 575: > >> 573: >> 574: #ifdef ASSERT >> 575: void InstanceKlass::assert_bounds_check(address addr, bool edge_ok, >> intptr_t size_in_bytes) const { > > 1) This function is broken w.r.t. bytes vs words in the "just after" check. > 2) The "before" checks is turned off for the checks of "start_" values. That > seems inconsistent and also makes me wonder if the before check really is > helping here. > > I would vote for nuking this function from JEP-401, but as a separate RFE. I haven't yet figured out why this was added. I'd like to remove it too. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2479#discussion_r3317579073
