On Mon, 1 Jun 2026 07:16:42 GMT, Joel Sikström <[email protected]> wrote:
> Hello, > > The StoreStore membar in the AArch64 implementation of TemplateTable::aaload > is redundant after > [JDK-8378862](https://bugs.openjdk.org/browse/JDK-8378862), which calls > `OrderAccess::storestore()` in the VM instead. > > I suggest we remove it so we don't have a double storestore-membar for this > path. I don't think we need a comment here explaining that the VM handles > memory ordering for us. > > Testing: > * Oracle's tier1-4 on linux-aarch64 release/fastdebug. > > > > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). This pull request has now been integrated. Changeset: 4c1a52bd Author: Joel Sikström <[email protected]> URL: https://git.openjdk.org/valhalla/commit/4c1a52bdd783bf9ce54fe018a7d444f670584b42 Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod 8385673: [lworld] Redundant StoreStore membar in AArch64 TemplateTable::aaload Reviewed-by: aboldtch, stefank, heidinga, fparain ------------- PR: https://git.openjdk.org/valhalla/pull/2495
