On Mon, 1 Jun 2026 19:37:09 GMT, Vicente Romero <[email protected]> wrote:

>> Simple PR removing some dead code and addressing review comments:
>> 
>> https://git.openjdk.org/jdk/pull/31121#discussion_r3277429408
>> https://git.openjdk.org/jdk/pull/31121#discussion_r3277431212
>> https://git.openjdk.org/jdk/pull/31121#discussion_r3277433565
>> https://git.openjdk.org/jdk/pull/31121#discussion_r3277436623
>> https://git.openjdk.org/jdk/pull/31121#discussion_r3277438177
>> 
>> ---------
>> - [X] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Vicente Romero has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   doc

src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties
 line 4407:

> 4405: 
> 4406: compiler.warn.value.finalize=\
> 4407:     value classes should not have finalize methods, as they are not 
> invoked

Suggestion:

    value classes should not have a finalizer method, as it is not invoked

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2499#discussion_r3340066070

Reply via email to