On Tue, 2 Jun 2026 10:24:53 GMT, Marc Chevalier <[email protected]> wrote:
>> Roland Westrelin has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> commits since the last revision:
>>
>> - review
>> - Merge branch 'lworld' into JDK-8302217
>> - more
>> - more
>> - cleanup
>> - more
>> - more
>> - more
>> - more
>> - fix
>
> src/hotspot/share/opto/cfgnode.cpp line 2949:
>
>> 2947: continue;
>> 2948: }
>> 2949: _nodes_from_phi.push(in);
>
> What would you think about a form like
>
> if (Node* in = n->in(1); in != nullptr) {
> _nodes_from_phi.push(in);
> }
>
> On top of being a bit shorter, it rather insist on what we do than the
> `continue` (that is not the interesting case). Feel free to ignore. No strong
> opinion.
Changed in new commit
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2316#discussion_r3341686499
