On Wed, 3 Jun 2026 13:10:11 GMT, Stefan Karlsson <[email protected]> wrote:

>> Hi,
>> 
>> These are the rest (so far) of @dholmes-ora suggested changes from the PR 
>> https://github.com/openjdk/jdk/pull/31122
>> 
>> ---------
>> - [X] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> src/hotspot/share/classfile/classLoaderStats.cpp line 39:
> 
>> 37:     // Direct instances of ObjArrayKlass represent the Java types that 
>> Java code can see.
>> 38:     // RefArrayKlass/FlatArrayKlass describe different implementations 
>> of the arrays, filter them out.
>> 39:     return k->is_objArray_klass() && k->kind() != 
>> Klass::KlassKind::ObjArrayKlassKind:
> 
> Suggestion:
> 
>     return k->is_objArray_klass() && k->kind() != 
> Klass::KlassKind::ObjArrayKlassKind;

FWIW, this could probably have been using:

bool is_refined_objArray_klass()      const { return is_refArray_klass() || 
is_flatArray_klass(); }

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2504#discussion_r3348734046

Reply via email to