On Wed, 3 Jun 2026 18:44:49 GMT, Chen Liang <[email protected]> wrote:

> The preview compilation of modules ignore class files supplied to module path 
> of normal compilation of modules. This introduces spurious errors when a 
> module has preview files and compiles against external class files at the 
> same time.
> 
> Also removed a useless `ifneq ($(COMPILER), bootjdk)` condition, please 
> review the diff without whitespace.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

The affected licensee builds have this line, as you evaluated before:

2025-11-06T15:43:43,252Z] checking if crypto source is available... no


In this case, the class files are fetched by the Oracle internal build system 
and dumped in `$(COMPILATION_OUTPUTDIR)/$(MODULE)`. We need to use patch-module 
to make the preview build respect these class files.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/2506#issuecomment-4617292983

Reply via email to