On Thu, 4 Jun 2026 21:57:16 GMT, Serguei Spitsyn <[email protected]> wrote:
>> The JDWP spec was suppose to be updated for all addInstanceFilter() APIs
>> with this minor clarification:
>>
>>
>> /**
>> * Restricts the events generated by this request to those in
>> * which the currently executing instance is the object
>> - * specified.
>> + * specified as determined by applying the "==" operator.
>> * <P>
>> * Not all targets support this operation.
>> * Use {@link VirtualMachine#canUseInstanceFilters()}
>>
>>
>> BreakpointRequest was used as the template and copied to the javadoc of the
>> other event request's addInstanceFilter(). However, BreakpointRequest had a
>> pre-existing omission, and as a result this omission got applied to all the
>> other addInstanceFilter() javadocs:
>>
>>
>> /**
>> * Restricts the events generated by this request to those in
>> - * which the currently executing instance ("this") is the object
>> - * specified.
>> + * which the currently executing instance is the object
>> + * specified as determined by applying the "==" operator.
>> * <P>
>> * Not all targets support this operation.
>> * Use {@link VirtualMachine#canUseInstanceFilters()}
>>
>>
>> The reference to "this" was incorrectly removed since it was missing from
>> BreakpointRequest. This was done by #2411. This PR adds "this" back in, and
>> also fixes BreakpointRequest to also include the "this" reference.
>>
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Looks good.
Thank you for the review @sspitsyn!
-------------
PR Comment: https://git.openjdk.org/valhalla/pull/2514#issuecomment-4633681402
