On Fri, 5 Jun 2026 20:04:48 GMT, Coleen Phillimore <[email protected]> wrote:

>> This change refactors the super class scalar argument checking code and 
>> deoptimization so that it is only called at link time and not for 
>> frame::describe() and other places that are only retrieving the calling 
>> convention.  The only time that we detect a mismatch is during class 
>> linking, before the overriding subclass method can run.
>> 
>> This avoids running vm code while thread_in_Java, which is unsafe, and 
>> removes the ThreadInVMfromUnknown, which was even more unsafe.
>> 
>> Tested with tier1-4.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Coleen Phillimore has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Some improvements.

Thank you for reviewing Patricio and Fred. Thanks for the discussion yesterday 
Patricio.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/2517#issuecomment-4635713643

Reply via email to