On Sat, 6 Jun 2026 00:32:47 GMT, Dan Smith <[email protected]> wrote:
> Serialization javadoc updates to address handling of abstract value classes, > and to clean up spec for Externalizable. > > > > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Seems largely `{@code` additions; reviewed the record externalizable and value section, looks good. The description about AVC declaring fields look good too. src/java.base/share/classes/java/io/Externalizable.java line 56: > 54: * created using the public no-arg constructor, then the > 55: * {@code readExternal} method called. > 56: * <p> Suggestion: * <p> src/java.base/share/classes/java/io/ObjectOutputStream.java line 331: > 329: * Serializable abstract value class that declares instance > fields, > 330: * can only be serialized if it is a record, or it > implements > 331: * {@code writeReplace}, or it is a boxed primitive value. Suggestion: * {@code writeReplace}, or it is a boxed primitive value. ------------- Marked as reviewed by liach (Committer). PR Review: https://git.openjdk.org/valhalla/pull/2522#pullrequestreview-4442005846 PR Review Comment: https://git.openjdk.org/valhalla/pull/2522#discussion_r3366846789 PR Review Comment: https://git.openjdk.org/valhalla/pull/2522#discussion_r3366849407
