On Mon, 8 Jun 2026 13:33:24 GMT, Roland Westrelin <[email protected]> wrote:
>> The bug is caused by a mismatch in the way `LoadFlat` and `StoreFlat` >> are handled in `ConnectionGraph::find_inst_mem()` and >> `MemNode::optimize_simple_memory_chain()`. Once EA has run a first >> time, found some value array allocations as non escaping, and removed >> their `LoadFlat`/`StoreFlat`, igvn runs and is able to further >> transform the memory subgraph which introduces inconsistencies that >> are then caught the next time EA runs. >> >> The fix tries to make sure `ConnectionGraph::find_inst_mem()` and >> `MemNode::optimize_simple_memory_chain()` handle `LoadFlat` and >> `StoreFlat` similarly. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Roland Westrelin has updated the pull request incrementally with one > additional commit since the last revision: > > more src/hotspot/share/opto/escape.cpp line 4554: > 4552: if (ptn->is_JavaObject()) { > 4553: Node* jobj_base = get_map(ptn->idx()); > 4554: if (jobj_base == nullptr || > _igvn->type(jobj_base)->is_oopptr()->instance_id() != toop->instance_id()) { I still don't like the raw instance_id() comparisons. Could we have something like _igvn->type(jobj_base)->is_oopptr()->same_instance(toop) based on something like meet_instance_id() or that asserts both are is_known_instance()? ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2489#discussion_r3391734650
