On Thu, 11 Jun 2026 06:17:00 GMT, Aleksey Shipilev <[email protected]> wrote:

>> src/hotspot/share/opto/inlinetypenode.cpp line 1381:
>> 
>>> 1379:     do_atomic = false;
>>> 1380:   }
>>> 1381:   if (do_atomic && UseShenandoahGC && vk->contains_oops()) {
>> 
>> Can you instead reject flattening if the member type contains an oop?
>
> Maybe, I would really like to mark the paths where we need more work, like 
> this. It follows the similar precedents in current Valhalla codebase, I think.

You can add `assert` here so that future support will notify the lack of 
support from C2 here.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/1971#discussion_r3394339563

Reply via email to