On Fri, 12 Jun 2026 15:56:58 GMT, Alan Bateman <[email protected]> wrote:
>> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits since the last revision: >> >> - does does >> - Merge branch 'lworld' of https://github.com/openjdk/valhalla into >> clean/lw-mod-clean >> - Correct defineHiddenClass BasicTest >> - Random cleanup drop > > test/jdk/java/lang/invoke/defineHiddenClass/BasicTest.java line 315: > >> 313: expectedAccessFlags |= ACC_IDENTITY; >> 314: } >> 315: assertEquals(hc.getModifiers(), expectedAccessFlags); > > Good, although probably expectedModifiers rather than expectedAccessFlags as > this method returns a mask that isn't necessarily the value of the access > flags from the class file. I think this would be okay because none of the tested empty hidden classes is a nested class, so this name "access flags" is accurate. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2536#discussion_r3406522634
