On Fri, 12 Jun 2026 23:51:16 GMT, Joe Darcy <[email protected]> wrote:

>> Since JEP 401 is targeting 28, we should update the since versions and 
>> rollback the checker test changes.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> test/jdk/tools/sincechecker/modules/java.base/JavaBaseCheckSince.java line 29:
> 
>> 27:  * @summary Test for `@since` in java.base module
>> 28:  * @library /test/lib /test/jdk/tools/sincechecker
>> 29:  * @run main/timeout=480 SinceChecker java.base --exclude 
>> java.lang.classfile
> 
> Why is java.lang.classfile being ignored?

This is something from @nizarbenalla before. I removed this and the 5 failures 
are 4 package `@since` "should be 22" and one `CompoundElement.forEach` "should 
be 22".

The packages are not tracked by the symbol files except as module export 
entries which can't be annotated, so we must use manual hardcoding. I haven't 
investigated how SinceChecker produces an older since for `forEach` compared to 
`CompoundElement`, maybe it saw `forEach` came from `Iterable` which was not 
preview in 22.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2533#discussion_r3406857496

Reply via email to