On Wed, 17 Jun 2026 20:14:24 GMT, Richard Reingruber <[email protected]> wrote:
>> Martin Doerr has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove untested from _fast_vgetfield. > > src/hotspot/cpu/ppc/macroAssembler_ppc.cpp line 3424: > >> 3422: call_VM_leaf(CAST_FROM_FN_PTR(address, >> BarrierSetRuntime::value_copy), src, dst, inline_layout_info); >> 3423: } >> 3424: } > > Other platforms define this in `BarrierSetAssembler::flat_field_copy()`. Is > there a reason we don't do the same on ppc64? I don't remember. And I don't know why it is in BarrierSetAssembler. We could move it on demand. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2549#discussion_r3434272445
