On Fri, 19 Jun 2026 11:53:52 GMT, Jaikiran Pai <[email protected]> wrote:
>> src/hotspot/share/runtime/synchronizer.cpp line 323:
>>
>>> 321: if ((obj)->mark().is_inline_type()) { \
>>> 322: JavaThread* THREAD = current; \
>>> 323: ResourceMark rm(THREAD); \
>>
>> Is the RM still needed?
>
> I wasn't aware what a `ResourceMark` is. Reading the code and the code
> comment on `ResourceMarkImpl`, I believe it was here for tracking the
> resource allocated in the implementation of `obj->klass()->external_name()`
> (please correct me if I'm wrong). With that now gone, I think the
> `ResourceMark` is no longer needed. I've updated the PR accordingly.
>
> I have triggered tier testing to be sure that this doesn't cause any issues.
tier1, tier2, tier3 testing of the latest changes in this PR completed without
any related failures.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2568#discussion_r3443682882
