On Tue, 23 Jun 2026 21:20:41 GMT, Vladimir Ivanov <[email protected]> wrote:

>> Roland Westrelin has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   more
>
> src/hotspot/share/opto/callGenerator.cpp line 187:
> 
>> 185:   kit.set_edges_for_java_call(call, false, _separate_io_proj);
>> 186:   Node* ret = kit.set_results_for_java_call(call, _separate_io_proj);
>> 187:   if (is_late_inline() && !call->is_boxing_method() && ret->is_Proj() 
>> && ret->in(0) == call) {
> 
> Why do you need `!call->is_boxing_method()` here?

That was in the mainline fix:
https://github.com/openjdk/jdk/pull/30088

The reason if I remember correctly is that `Node::is_dead_loop_safe()` has some 
custom logic for `is_boxing_method()`

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2575#discussion_r3466666608

Reply via email to