On Fri, 26 Jun 2026 14:09:45 GMT, Tobias Hartmann <[email protected]> wrote:
>> I think we need to detect spills in conditional code at compile time. >> >> I'm not convinced creating a new virtual register for "load_result" here is >> correct either. It moves the problem to a different virtual register, one >> that has a shorter lifetime that "result", but does that guarantee there >> won't be a spill? We are still setting a register in two different paths >> that are invisible to C1 LIR. > > I agree with Dean. I think it's the same problem I described in > [JDK-8353851](https://bugs.openjdk.org/browse/JDK-8353851). Maybe setting `LIRGenerator::set_in_conditional_code` here like we do as mitigation in Load/StoreIndexed would help? ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2579#discussion_r3481934825
