On Wed, 1 Jul 2026 09:50:57 GMT, Alan Bateman <[email protected]> wrote:
>> This update is for Valhalla pre-integration. It introduces new JVMTI >> capability `can_support_value_objects`. >> The variable `_can_support_value_objects_count` is introduced for >> optimization. It follows the pattern of the `can_support_virtual_threads` >> capability. >> >> Additionally, this update includes test fixes: >> - >> test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.cpp: >> - Removed the `if (!jni->HasIdentity(object))` check because it is not >> needed anymore as the JVMTI capability `can_support_value_objects` is no >> acquired by the test >> >> - These two tests are updated to provide both positive and negative >> coverage for new capability: >> test/hotspot/jtreg/serviceability/jvmti/valhalla/VMObjectAllocValue >> test/hotspot/jtreg/serviceability/jvmti/valhalla/SampledObjectAllocValue >> >> Testing: >> - Ran updated tests locally >> - Submitted mach5 tiers 1-6 >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > src/hotspot/share/prims/jvmti.xml line 14028: > >> 14026: When preview features are enabled and the capability >> <code>can_support_value_objects</code> >> 14027: is enabled, this event is sent for the allocated objects that >> have no identity. >> 14028: <code>null</code> is passed for the <paramlink >> id="object"></paramlink> parameter in such cases. > > As the capability is "can_support_value_objects" then it may be simpler to > just say that it sent for value objects when that capability is enabled, > otherwise you end up with both "value objects" and "no identity" in the same > sentence. Agreed, thanks. Fixed now. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2607#discussion_r3508184591
