On Wed, 1 Jul 2026 18:10:12 GMT, Chris Plummer <[email protected]> wrote:
>> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits since the last revision: >> >> - Improve test, quality docs update to be for when preview features are >> enabled >> - Merge branch 'lworld' into ForceEarlyReturn >> - Improve docs change >> - Test cleanup >> - Initial commit > > src/hotspot/share/prims/jvmti.xml line 3384: > >> 3382: a return type of <code>void</code>. A class initializer is a >> special >> 3383: method named named <code><clinit></code> with a return >> type of >> 3384: <code>void</code>. > > I'm not sure of the purpose of calling out what constructors and class > initializers are. This is setup for the sentence that follows. Without it, it would be too much of a surprise to say that the function cannot be used to return early from the constructor of a value class. > src/hotspot/share/prims/jvmti.xml line 3405: > >> 3403: The implementation is unable to force the current frame to >> return >> 3404: (e.g. current frame is executing a native method or the >> current frame is the >> 3405: constructor for a value class) > > I think you still need to mention "when preview mode is enabled" here. I know > you already did in the description, but seems to me it should be repeated > here. Okay although I don't think it is strictly needed as it's already in the description (as you noted). ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2604#discussion_r3508192648 PR Review Comment: https://git.openjdk.org/valhalla/pull/2604#discussion_r3508196781
