On Thu, 2 Jul 2026 13:03:34 GMT, Jaikiran Pai <[email protected]> wrote:
>> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits since the last revision: >> >> - Review comments, a few more cases >> - Merge branch 'lworld' of https://github.com/openjdk/valhalla into >> fix/lw-ser-strict-in-super >> - Another case >> - Make sure serialization fails for "strict in serializable super" > > test/jdk/java/io/Serializable/valueObjects/ValueSerializationTest.java line > 270: > >> 268: @ParameterizedTest >> 269: @MethodSource("classes") >> 270: void testDeser(Class<?> valueClass, byte flags, Class<? extends >> Exception> expectedException) > > Now that the incoming `Class` is not always a value class, I think we should > rename this parameter to just `cls` or something else. At the same time, the > comment on the test method would need an update too, maybe: > >> A byte stream is generated containing a reference to the given class ... Done. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2612#discussion_r3513748012
