On Thu, 2 Jul 2026 14:50:38 GMT, Chen Liang <[email protected]> wrote:
>> Reflective preview APIs can be used out of preview. Thus it is meaningful >> for us to note how they behave when preview features are disabled. >> >> I hope this can clarify some common misconceptions and help onboarding to >> the JEP 401 reflection model. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains eight additional commits since > the last revision: > > - Alan reviews > - Merge branch 'lworld' of https://github.com/openjdk/valhalla into > doc/lw-reflect-preview-api-0 > - Merge branch 'lworld' of https://github.com/openjdk/valhalla into > doc/lw-reflect-preview-api-0 > - Merge branch 'lworld' of https://github.com/openjdk/valhalla into > doc/lw-reflect-preview-api-0 > - Merge branch 'lworld' of https://github.com/openjdk/valhalla into > doc/lw-reflect-preview-api-0 > - Reword recommendations > - Make requireIdentity reflective > - Reflective preview API behavior out of preview I’d still keep “represents” here as well, to make the meanings wholly unambiguous: src/java.base/share/classes/java/lang/Class.java line 1394: > 1392: * represents either a class whose {@code class} file does > not > 1393: * depend on preview features or an array type, its {@code > identity} > 1394: * modifier is always true. Suggestion: * represents either a class whose {@code class} file does not * depend on preview features or represents an array type, * its {@code identity} modifier is always true. src/java.base/share/classes/java/lang/Class.java line 1460: > 1458: * represents either a class whose {@code class} file does > not > 1459: * depend on preview features or an array type, its flags > always > 1460: * include {@code IDENTITY}. Suggestion: * depend on preview features or represents an array type, its flags * always include {@code IDENTITY}. ------------- PR Review: https://git.openjdk.org/valhalla/pull/2578#pullrequestreview-4619329384 PR Review Comment: https://git.openjdk.org/valhalla/pull/2578#discussion_r3514566873 PR Review Comment: https://git.openjdk.org/valhalla/pull/2578#discussion_r3514568400
