On Thu, 9 Jul 2026 04:50:31 GMT, David Holmes <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - review: one more minor tweak >> - review: minor correction > > src/hotspot/share/prims/jvmti.xml line 937: > >> 935: and >> 936: <externallink >> id="jni/functions.html#newweakglobalref"><code>NewWeakGlobalRef</code></externallink>, >> 937: specify the JNI behavior for value objects. Any additional >> JVMTI-specific behavior > > I don't think we need to say all this. It really isn't for the JVMTI spec to > state where the JNI spec may treat objects with/without identity differently, > and individual JVMTI methods that behave differently already state that you > can use `HasIdentity` to query that. I would keep this very succinct as I did > for the JNI spec itself: >> If preview features are enabled then some Java objects will have identity >> and others (instances of value classes) will not. The JNI makes no >> distinction between these cases in the general programming model, but some >> specific functions will behave differently if invoked upon a Java object >> that does not have identity. > > So for JVMTI then something like: >> If preview features are enabled then some Java objects will have identity >> and others (instances of value classes) will not. `<jvmti/>` makes no >> distinction between these cases in general, but some specific functions will >> behave differently if invoked upon a Java object that does not have identity. Thanks, David. Updated as you suggested. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2634#discussion_r3557731702
