On Mon, 13 Jul 2026 00:58:14 GMT, Chris Plummer <[email protected]> wrote:
>> src/jdk.jdi/share/classes/com/sun/jdi/ObjectReference.java line 72: >> >>> 70: * <cite>The Java Virtual Machine Specification</cite>. >>> 71: * <p> >>> 72: * Where JDI does differ from the JLS is in allowing the user to obtain >>> an >> >> I don't think this conversational style is suitable for this kind of API >> spec. The spec should just say what happens, not what it differs from. I >> would phrase more succinctly as: >>> If an ObjectReference is obtained for a value object under construction, >>> then it is a snapshot of the value object at that point in time. Any >>> further changes to the initialization state of the value object will not be >>> reflected in the initial ObjectReference. > > Ok. I'll work on this. After re-reviewing you comments, it seem the only thing you really want in this section is to say "JDI supports value objects" and then mention the constructor warning you've written above. The latter isn't really adding any value since it is already explained in ObjectRefernece.thisObject(), so then this section boils down to "JDI supports value objects". ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2639#discussion_r3573990603
