Hi David,
I'm reviewing the core reflection and j.l.invoke spec change.
I think Class::getNestHost and Class::getNestMembers should do a security
permission check as performed in other method e.g. getEnclosingClass.
* @throws SecurityException
* If a security manager, <i>s</i>, is present and
* the caller's class loader is not the same as or an
* ancestor of the class loader for the current class and
* invocation of {@link SecurityManager#checkPackageAccess
* s.checkPackageAccess()} denies access to the package
* of this class
*
I suggest to make @apiNote in Class::getNestHost as just part of javadoc.
It can define a section like "Nest Membership" that can be referenced
by Lookup class spec. I also have some suggested edits that you can
consider:
http://cr.openjdk.java.net/~mchung/valhalla/webrevs/nestmates-spec/
Mandy
On 3/6/18 10:12 PM, David Holmes wrote:
The Nestmates CSR request:
https://bugs.openjdk.java.net/browse/JDK-8197445
has been prepared by Dan Smith and myself. Before Proposing this CSR
request it needs to have Reviewers add themselves to it.
(The first reviewer will need to edit the issue to enter their OpenJDK
user name in the "Reviewed by" field. Subsequent reviewers can simply
click on the "Reviewed by" field in the "People" section and add their
user name.
The CSR contains links to all the updated specification documents, all
of which have been previously sent out for review/comment to the EG
(and observers).
Thanks,
David
