Hi,

on (Open)Solaris, test m00000.vtc will fail because of getcwd(NULL, 0) in vtc.c
returning NULL.

from getcwd(3C) :

     If buf is a null pointer, getcwd()  obtains  size  bytes  of
     space using malloc(3C). The pointer returned by getcwd() can
     be used as the argument in a subsequent call to free().

Thanks, Nils
Index: vtc.c
===================================================================
--- vtc.c       (revision 5239)
+++ vtc.c       (working copy)
@@ -657,8 +657,10 @@
        AZ(mkdir(vtc_tmpdir, 0700));
        macro_def(vltop, NULL, "tmpdir", vtc_tmpdir);
 
-       cwd = getcwd(NULL, 0);
+       cwd = getcwd(NULL, BUFSIZ);
        bprintf(topbuild, "%s/%s", cwd, TOP_BUILDDIR);
+       free(cwd);
+       cwd = NULL;
        macro_def(vltop, NULL, "topbuild", topbuild);
 
        AZ(pthread_mutex_init(&vtc_mtx, NULL));

_______________________________________________
varnish-dev mailing list
[email protected]
http://lists.varnish-cache.org/mailman/listinfo/varnish-dev

Reply via email to