In message <[email protected]>, Mart
in Blix Grydeland writes:

>Attached is code proposed to resolve ticket #780 on vanish-cache.org. 

Looks good, but I'm worried if it is too strict.

RFC2616 p166 "19.3 Tolerant Applications" suggest that we don't mandate
exact CR+LF, but rather:

   The line terminator for message-header fields is the sequence CRLF.
   However, we recommend that applications, when parsing such headers,
   recognize a single LF as a line terminator and ignore the leading CR.

So I think the right logic is more like:

        c = Rx one char
        if (c == CR)
                Rx one char
        if (c != LF)
                accept fetch
                log error notice
                close connection to prevent reuse
        
-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
[email protected]         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

_______________________________________________
varnish-dev mailing list
[email protected]
http://lists.varnish-cache.org/mailman/listinfo/varnish-dev

Reply via email to