On Sat, Jan 22, 2011 at 08:50, Poul-Henning Kamp <[email protected]> wrote:
> I think I would prefer if we could do this in libvarnishapi instead > of in varnishstat, it seems generally useful at libvarnishapi level > to me. > I think it would be possible to move this into the library instead. How does (should/will) this work with dynamic stats counters ? > Not entirely sure what you mean by that? Please elaborate. +struct stat stat; > > Naming a struct "stat" is often asking for more trouble than it is > worth. "struct stat" is what stat(2) and fstat(2) returns and because > of various levels of compatibility junk (32/64 bit typically) it can > be seriously magicked by compilers. > Good point, I will rename that variable. -Martin -- Martin Blix Grydeland Varnish Software AS
_______________________________________________ varnish-dev mailing list [email protected] http://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
