Tested. The leak is gone. www.varnish-cache.org updated, recompiled and restarted. I've added some ESI processing to the mix for good measure. :-)
Per. On Sat, Mar 12, 2011 at 3:47 PM, Poul-Henning Kamp <[email protected]>wrote: > In message <[email protected]>, > Per > Buer writes: > > I think I've fixed this, a stupid oversight on my part. > > Please test again, when possible. > > Poul-Henning > > >--0015174c3d4addc4d1049e447a1e > >Content-Type: text/plain; charset=ISO-8859-1 > > > >Hi. > > > >I've been running trunk on varnish-cache.org since yesterday (14:00) and > >there a leak there. Turning off http_gzip_support seems to eliminate the > >leak. > > > >Reproducing the leak is quite simple. Just hammer varnish with a client > that > >doesn't send accept-encoding: gzip. > > > > > >Per. > > > >On Sat, Mar 12, 2011 at 12:45 AM, Dmitry Panov <[email protected] > >wrote: > > > >> Hi Poul, > >> > >> I think I found the reason. I tried the same test but with > >> http_gzip_support=off and it worked fine. tsung does not support gzip so > >> varnish had to gunzip objects for it and this is where the leak appears > to > >> be. Hope it helps. > >> > >> > >> > >> On 11/03/2011 14:06, Poul-Henning Kamp wrote: > >> > >>> In message<[email protected]>, Dmitry Panov writes: > >>> > >>> Both. The patch doesn't make any difference. > >>>> > >>> Ok, that makes it my department :-) > >>> > >>> Any indication what the leak depends on ? > >>> > >>> number of requests ? > >>> > >>> size of requests ? > >>> > >>> hit rate ? > >>> > >>> > >> > >> -- > >> Dmitry Panov > >> > >> > >> > >> _______________________________________________ > >> varnish-dev mailing list > >> [email protected] > >> http://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev > >> > > > > > > > >-- > >Per Buer, Varnish Software > >Phone: +47 21 98 92 61 / Mobile: +47 958 39 117 / Skype: per.buer > >Varnish makes websites fly! > >Want to learn more about Varnish? > >http://www.varnish-software.com/whitepapers > > > >--0015174c3d4addc4d1049e447a1e > >Content-Type: text/html; charset=ISO-8859-1 > >Content-Transfer-Encoding: quoted-printable > > > >Hi.<div><br></div><div>I've been running trunk on <a href=3D" > http://var= > >nish-cache.org" target=3D"_blank">varnish-cache.org</a> since yesterday > (14= > >:00) and there a leak there. Turning off http_gzip_support seems to > elimina= > >te the leak.</div> > > > ><div><br></div><div>Reproducing the leak is quite simple. Just hammer > varni= > >sh with a client that doesn't send accept-encoding: > gzip.</div><div><br= > >></div><div><br></div><div>Per.<br><br><div class=3D"gmail_quote">On Sat, > M= > >ar 12, 2011 at 12:45 AM, Dmitry Panov <span dir=3D"ltr"><<a > href=3D"mail= > >to:[email protected]" target=3D"_blank">[email protected] > </a>= > >></span> wrote:<br> > > > > > ><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 > .8ex;border-left:1p= > >x #ccc solid;padding-left:1ex">Hi Poul,<br> > ><br> > >I think I found the reason. I tried the same test but with > http_gzip_suppor= > >t=3Doff and it worked fine. tsung does not support gzip so varnish had to > g= > >unzip objects for it and this is where the leak appears to be. Hope it > help= > >s.<div> > > > > > ><br> > ><br> > ><br> > >On 11/03/2011 14:06, Poul-Henning Kamp wrote:<br> > ><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 > .8ex;border-left:1p= > >x #ccc solid;padding-left:1ex"> > >In message<<a href=3D"mailto:[email protected]"; > target=3D"_bl= > >ank">[email protected]</a>>, Dmitry Panov writes:<br> > ><br> > ><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 > .8ex;border-left:1p= > >x #ccc solid;padding-left:1ex"> > >Both. The patch doesn't make any difference.<br> > ></blockquote> > >Ok, that makes it my department :-)<br> > ><br> > >Any indication what the leak depends on ?<br> > ><br> > >number of requests ?<br> > ><br> > >size of requests ?<br> > ><br> > >hit rate ?<br> > ><br> > ></blockquote> > ><br> > ><br> > >-- <br></div><font color=3D"#888888"> > >Dmitry Panov</font><div><div></div><div><br> > ><br> > ><br> > >_______________________________________________<br> > >varnish-dev mailing list<br> > ><a href=3D"mailto:[email protected]"; > target=3D"_blank">varnish-= > >[email protected]</a><br> > ><a href=3D" > http://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev"= > > target=3D"_blank"> > http://www.varnish-cache.org/lists/mailman/listinfo/varn= > >ish-dev</a><br> > ></div></div></blockquote></div><br><br clear=3D"all"><br>-- <br>Per Buer,= > >=A0Varnish Software<br>Phone: +47 21 98 92 61 / Mobile: +47 958 39 117 / > Sk= > >ype: per.buer<br>Varnish makes websites fly!<br>Want to learn more about > Va= > >rnish? <a href=3D"http://www.varnish-software.com/whitepapers"; > target=3D"_b= > >lank">http://www.varnish-software.com/whitepapers</a><br> > > > > > ><br> > ></div> > > > >--0015174c3d4addc4d1049e447a1e-- > > > > -- > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > [email protected] | TCP/IP since RFC 956 > FreeBSD committer | BSD since 4.3-tahoe > Never attribute to malice what can adequately be explained by incompetence. > -- Per Buer, Varnish Software Phone: +47 21 98 92 61 / Mobile: +47 958 39 117 / Skype: per.buer Varnish makes websites fly! Want to learn more about Varnish? http://www.varnish-software.com/whitepapers
_______________________________________________ varnish-dev mailing list [email protected] http://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
