On 18 April 2011 18:06, Laurence Rowe <[email protected]> wrote: > On 15 April 2011 09:39, Tollef Fog Heen <[email protected]> wrote:> >> Hi, I've attached my suggested fix for #900. As a side effect, it >> allows you to embed binary data in arbitrary strings, so you can serve >> PNG or GIF images from vcl_error. >> >> Comments very welcome, both on the approach and what we should allow. > > Allowing binary data in vcl strings (I'm assuming \0 is what's missing > here currently) sounds really useful in conjunction with the new > vmod_digest module - I'm interested in being able to extract and > validate signed authentication cookies in my VCL and the more of the > string manipulation that can be done in VCL rather than C code, the > easier that will be.
Having looked at the patch, I see that you're only changing the vcl parser. Supporting arbitrary binary data in strings will require support for null bytes, but vcl strings are currently null terminated if I remember correctly? Laurence _______________________________________________ varnish-dev mailing list [email protected] http://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
