Yep, the multi-pass way is not *fast*, but for the common cases, aka. GMT is fine, sure, I should adjust "GMT" to be the number one in the array.
I will think of your idea against replacing strptime as well. Glad to receive the feedback from you. Thanks On 6 Jun, 2012, at 8:04 PM, Poul-Henning Kamp wrote: > In message <[email protected]>, Jammy writes: > >> These days, we met with some Expire headers with following format which = >> are not supported by varnish yet. >> Sun, 06 Nov 1994 08:49:37 +0000 > > There is no requirement to support this format, see RFC2616, section > 3.3.1, and I'm not particularly keen on the multi-pass way your > patch solves it, since I have an item on my list that we should > write something faster than strftime() which does a lot of work we > don't need. > > (Belive it or not, but at high loads strftime() shows up in > profiling!) > > If you would like to take a stab at that, you are more than > welcome. > > -- > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > [email protected] | TCP/IP since RFC 956 > FreeBSD committer | BSD since 4.3-tahoe > Never attribute to malice what can adequately be explained by incompetence. ---------------------------------- Best wishes, Jammy
_______________________________________________ varnish-dev mailing list [email protected] https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
