This then also breaks the previous expectation that cur_seg would always be non-NULL. Change the code to take this into account.
Review comments: + ALLOC_OBJ(sg, SMP_SEG_MAGIC); > + AN(sg); > Instead of AN, you should just return failure. We should handle > malloc failures gracefully where we can easily do so. Returning failure in this case now. In both the next two cases, you should consider truncation > of the new segment, it's silly to waste a full segment if > the overflow is just one page: Added XXX-comments on truncation suggestion. For clarity, always keep left in sync with cur_seg: Done -- Martin Blix Grydeland Varnish Software AS
0007-Don-t-exit-on-full-silo.patch
Description: Binary data
_______________________________________________ varnish-dev mailing list [email protected] https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
