Review comments:

All things considered, we should probably VSL these and live with
> it.   SLT_PersistentEvent or something.


Agreed, logging from persistent needs to be overhauled as a
whole. Putting on todo list.

We should avoid whole-second sleeps, they have a bad tendency to
> get things to run in lockstep.  Ideally each silo should sleep
> for 1+random-small-delta, but at least make it different from 1.0


Changed

You should simply let the tread die, and pthread_join() it from
> smp_close().


Implemented



-- 
Martin Blix Grydeland
Varnish Software AS

Attachment: 0010-smp_thread-stopping.diff
Description: Binary data

_______________________________________________
varnish-dev mailing list
[email protected]
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev

Reply via email to