-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 10/15/2013 01:56 PM, Martin Blix Grydeland wrote: > > I am missing a Treq field, which is the time it took to send the request > to the backend in the first place. Would be used to search for network > issues (or slow piping of passed client request bodies).
OK. The only concern here (and the only reason I left it out) is that it would require another syscall per backend fetch (VTIM_real just before sending the request). But if we're sure we can afford that, then let's do it. > Also I think we should have the total backend response time in seconds > as a separate field. Short version: agreed %^) Especially since it's just a little more math. > Lastly, I think mimicking ReqEnd is a goal in itself, and to do that we > should think about the vxid that is present on ReqEnd. But in Varnish 4 > the vxid is part of every log record always, so here I believe we should > remove the vxid from ReqEnd instead. ReqEnd also doesn't have the vxid in the log payload any more (at least the last time I tested V4). And I agree, with the new logging API it doesn't have to. > So my suggestion on the fields present is: > BereqEnd <Tstart> <Tend> <dTreq> <dThdr> <dTbody> <dTresp> > > Tstart: begin fetch processing (epoch) > Tend: end fetch processing (epoch) > dTreq: time to send the backend request > dThdr: time to receive the backend response headers > dTbody: time to receive the backend response body > dTresp: time to receive the backend response (dThdr + dTbody) Will do! I'll send up another patch. Best, Geoff - -- ** * * UPLEX - Nils Goroll Systemoptimierung Scheffelstraße 32 22301 Hamburg Tel +49 40 2880 5731 Mob +49 176 636 90917 Fax +49 40 42949753 http://uplex.de -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJSXTZPAAoJEOUwvh9pJNUR3GQQAKLLhKlNbru3bjp3W8KcsLkF vFy2/C1ZsOCqM40USMkD7JTq4FzoTOaziXxHSjrCQCSs7WXSUX7OVoObYBWpxSr4 3GQlCrVkp9fSSoarFY7sjnBe3wyrXi+wVoJ/ESsiV0bqBqwS2OfYmkFhcaJ93kJX B8QuxfekEXE7S9xtB2G4q3hh62LcxaPNCTaTZn5vaG1k5D5urYwSiE3PFepikU/e 7XxeFB32xFOQFyA2RyLcti4i9Hefd6tjIptnLYp3dxPJc2f0JO9BJptngoWfeH4r 2QbnqcpHDtJ7FsnWOOxpLaqAHXUUgMoAv2F1F9wnkVmvcinzaj9jXYdWhrCilND8 9Mak1MiTtBWmhCiRrUVT4VSwCTgA08l3RDx9sOgVisVkRaC8wdUI3m6nAbaaD0Gn sfquZlIhUAb8uk9YLYDUWQmLEEdeSh1tm3q20hV6ORbFxs0TOUYA0KIW0Id8LXf5 k4Uq2832qFZFP+n9Pt6gUcqAG40mK0MpeYGKww+hqeFxSOnackf0xJmKOE+PU+wC GVNWABWYEQXRlXsNZaxz3piK00F3p1gH6CyjJxVPvYWg7apV6B21qFxAlAZUcEek fnHoNTgHxd1fuCpjrLsBewuNZxJxpppv0yR30W+OC7NHz8IK1kTmZNoElBJiQDgM l5801XlqSCwqJc4g4LBZ =TwNo -----END PGP SIGNATURE----- _______________________________________________ varnish-dev mailing list [email protected] https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
