Hi,

On 07/01/15 01:51, Federico Schwindt wrote:
> Can we just do:
> 
>     return (ctx->req->is_hit ? ctx->req->objcore->hits : 0);

Sounds like a good idea.

> in VRT_r_obj_hits() and revert this commit altogether?

will do.

> I'm not sure whether this was discussed but besides the macros now having the
> wrong names (REQ_FLAG and VREQ[WR][01] used for other variables than req) 
> adding
> more knobs is not the way to go IMO.

The REQ in REQ_FLAG and VREQ[WR][01] refers to struct req, not the VCL object.

Thanks, Nils

_______________________________________________
varnish-dev mailing list
[email protected]
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev

Reply via email to