I prefer to let the user decide (i.e. no auto-scaling). This is what top in linux does as well. The changes required were small enough as well.
That said if the consensus is to go for auto-scaling that's fine with me. Regarding adding the i to the unit, I've kept it brief on purpose to maintain the width as wide as possible. I've documented the units so this shouldn't be a problem. Also this is how top displays it. On Wed, Jan 7, 2015 at 11:49 AM, Nils Goroll <[email protected]> wrote: > Hi, > > I've reviewed and tested the patches and they look fine to me. > > But my personal preference would be auto-scaling per value, for instance > so that > you never get more than 3 digits or using the next unit when reaching 90% > of its > base value. > > I'd suggest a -h(uman readable) command line option plus an interactive > toggle key. > > If there is a good use case for manual sc(e)ling is, I don't mind keeping > it. > > Nils >
_______________________________________________ varnish-dev mailing list [email protected] https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
