Hello Nils, Thank you for your patch. I tested it just now and I didn't see any memory increase caused by "expire superseded" objects.
Thanks, Jingyi Wei On 01/07/15 10:55, Nils Goroll wrote: > Hi, > > could you please retest master 0302e16e8888d9213931077b9b331f72dcc018b6 or > newer? > > Thanks, Nils > > On 19/12/14 10:36, Nils Goroll wrote: >> On 19/12/14 02:14, Jingyi Wei wrote: >>> I see that >>> bo->ims_obj is set in VBF_Fetch() only if Last-Modified or ETag header >>> exists in the previous backend response. Otherwise |ims_obj| is NULL and >>> the memory will not be freed, so the actual problem is that there's no >>> Last-Modified header in our backend response. >> Good point, thank you. LM or ETag are required for issuing a backend >> conditional >> request, but this should be independent of freeing the superseded object. I >> will >> look after this unless someone else does. >> >> Nils >> >> _______________________________________________ >> varnish-dev mailing list >> [email protected] >> https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev >> > _______________________________________________ varnish-dev mailing list [email protected] https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
