Hello all, Currently a VSL tool such as varnishlog crashes with the option -L 0 when the first transaction is read -- AN(vtx) in vsl_dispatch.c, since the vslq->incomplete list is empty.
Transaction limit 0 doesn't make any sense, so this patch enforces -L > 0. Best, Geoff -- ** * * UPLEX - Nils Goroll Systemoptimierung Scheffelstraße 32 22301 Hamburg Tel +49 40 2880 5731 Mob +49 176 636 90917 Fax +49 40 42949753 http://uplex.de
diff --git a/lib/libvarnishapi/vsl_arg.c b/lib/libvarnishapi/vsl_arg.c index 24483c9..e6b2b89 100644 --- a/lib/libvarnishapi/vsl_arg.c +++ b/lib/libvarnishapi/vsl_arg.c @@ -343,7 +343,7 @@ VSL_Arg(struct VSL_data *vsl, int opt, const char *arg) p++; if (*p != '\0') return (vsl_diag(vsl, "-L: Syntax error")); - if (l < 0 || l > INT_MAX) + if (l <= 0 || l > INT_MAX) return (vsl_diag(vsl, "-L: Range error")); vsl->L_opt = (int)l; return (1);
signature.asc
Description: OpenPGP digital signature
_______________________________________________ varnish-dev mailing list [email protected] https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
