WRT this patch, I'm unclear where the implicit uninitialized read mentioned in the commit message occurs. The only members read/written from a `vr` attached to the `r_bogus` list are `len` and `ptr`, which are both assigned immediately after a successful allocation. (And that memory range is not shared between concurrent processes.)
Also minor nits in the comment: you typoed "avoid" and "available", and one of the `sc->g_overflow` should be `sc->c_overflow`. On Tue, Mar 8, 2016 at 2:40 AM, Pål Hermunn Johansen <[email protected]> wrote: > Hello, > I just started working at Varnish Software (last Thursday), and I am > looking forward to working with the Varnish Cache code. After firm > guidance from Martin, I am proposing my first patch. > > Best Regards, > > Pål Hermunn Johansen > > _______________________________________________ > varnish-dev mailing list > [email protected] > https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev _______________________________________________ varnish-dev mailing list [email protected] https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
