Travel day today, so I can't easily pull at the moment. This is about the first command, so comment lines before 'varnishtest' don't matter?
slink and I use the emacs -*- magic in a comment in the first line to set a VCL-friendly major mode. Best, Geoff Sent from my iPhone > On May 4, 2016, at 3:45 PM, Poul-Henning Kamp <[email protected]> wrote: > > -------- > In message > <CABoVN9A3ksCRU7iVoh=mv-8h5xfe9fmznrd8f+dzu_j_vqm...@mail.gmail.com> > , Dridi Boukelmoune writes: >>> On Wed, May 4, 2016 at 3:17 PM, Poul-Henning Kamp <[email protected]> wrote: >>> >>> commit 376bc2743d373233b2e703352acb3b64e95c71ef >>> Author: Poul-Henning Kamp <[email protected]> >>> Date: Wed May 4 13:15:34 2016 +0000 >>> >>> Insist that tests start out with the magic string >>> "varnishtest[:whitespace:]" >> >> Hi, >> >> This commit breaks usage of shebangs or copyright notices at the >> beginning of test scripts. >> >> Can I send a patch to fail a test at the end if the title wasn't set? > > I looked at how hard it would be to test for the first command being > "varnishtest" and just did the Q&D thing instead. > > I would strongly prefer we insist it be the first command, so that we > can use it for versioning down the road. > > > -- > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > [email protected] | TCP/IP since RFC 956 > FreeBSD committer | BSD since 4.3-tahoe > Never attribute to malice what can adequately be explained by incompetence. > > _______________________________________________ > varnish-dev mailing list > [email protected] > https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev _______________________________________________ varnish-dev mailing list [email protected] https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
