Just thinking about efficiency. In KeyBuffer and PieceSlot, when a piece is deselected, the Properties.SELECTED property is set to null rather than Boolean.FALSE. Is there any particular reason for this? With Global Markers, a lookup of getProperty(Properties.SELECTED) (which happens fairly often) will drop through to the Map and GameModule property lookups,
Cheers, Brent. *********** REPLY SEPARATOR *********** On 2/12/2005 at 2:43 PM Rodney Kinney wrote: > Rodney, we discussed this briefly earlier. I just had a thought, what > about implementing 'Global Markers' as a Map and/or GameModule component > that allow you to set property values at Map or Module level. These would > have a button that pops up a list of Global Markers and allows their values > to be changed. If BasicPiece.getProperty() is always called last at the > end of getProperty() call chain, if the property has not been resolved, then > it could pass the call to Map.getProperty(), if still unresolved, then it > gets passed on to GameModule.getGameModule().getProperty(). > > In combination with a variable radius, this would solved my Night > Visibility problem and I am it would be useful for other things. I like this idea a lot. Definitely code it up if you're interested. You can enhance the AreaOfEffect trait too. Mostly, I didn't want to have two equivalent traits in the engine, and I was too lazy to move everything from your trait into the existing one, but whatever you want to add back is fair game. rk [Non-text portions of this message have been removed] YAHOO! GROUPS LINKS Visit your group "vassalengine" on the web. To unsubscribe from this group, send an email to: [EMAIL PROTECTED] Your use of Yahoo! Groups is subject to the Yahoo! Terms of Service. ____________________________________________________________ Brent Easton Analyst/Programmer University of Western Sydney Email: [EMAIL PROTECTED] [Non-text portions of this message have been removed] ------------------------ Yahoo! Groups Sponsor --------------------~--> Get fast access to your favorite Yahoo! Groups. Make Yahoo! your home page http://us.click.yahoo.com/dpRU5A/wUILAA/yQLSAA/IMSolB/TM --------------------------------------------------------------------~-> Yahoo! Groups Links <*> To visit your group on the web, go to: http://groups.yahoo.com/group/vassalengine/ <*> To unsubscribe from this group, send an email to: [EMAIL PROTECTED] <*> Your use of Yahoo! Groups is subject to: http://docs.yahoo.com/info/terms/
