The problems in deleteSnapshot() should be fixed now as well. Please check the next sync. Deleting snapshot only failed if the snapshot was taken in the same session (i.e. without a VBoxSVC restart) because VBoxSVC failed to update medium backreferences correctly after a snapshot was taken.
Huihong Luo wrote: > Achim, > > No problem, and no harms meant. Your team has done an excellent job > considering such a complex project. > > - Huihong > > --- On *Fri, 11/6/09, Achim Hasenmueller /<[email protected]>/* wrote: > > > From: Achim Hasenmueller <[email protected]> > Subject: Re: [vbox-dev] VBoxSvc crash when deleting snapshots > To: "Huihong Luo" <[email protected]> > Cc: "Ulrich Moeller" <[email protected]>, "Sander Van Leeuwen" > <[email protected]> > Date: Friday, November 6, 2009, 11:50 PM > > Huihong, > > SVN is bleeding edge. Alternatively we could only sync SVN at > certain points where we've performed limited QA. This would give you > hundreds of changesets at once maybe every month or even less often. > SVN is for developers like you and your feedback helps us to iron > out bugs fast. Snapshots had several major regressions (our internal > developers suffered, too) but they are being addressed as fast as we > can and we expect it to be stable again early next week. > > -- > Achim Hasenmueller > Director Engineering, VirtualBox > Sun Microsystems GmbH > Werkstrasse 24 > 71384 Weinstadt, Germany > phone: +49 7151 604050 > > ================================================ > Sitz der Gesellschaft: Sun Microsystems GmbH, > Sonnenallee 1, 85551 Kirchheim-Heimstetten > Amtsgericht Muenchen: HRB 161028 > Geschaeftsfuehrer: Thomas Schroeder, > Wolfgang Engels, Wolf Frenkel > Vorsitzender des Aufsichtsrates: Martin Haering > ================================================ > > > > > > On Nov 6, 2009, at 21:42 , Huihong Luo wrote: > >> tried latest code, crash is gone, but deleting snapshots still not >> working as expected >> >> (1) start a vm, take snapshot >> (2) install something, e.g., firefox, to the vm >> (3) shutdown vm >> (4) now trying to delete the vm, I got "Failed to delete snapshot" >> error >> >> Quite the console, kill VBoxSVC.exe, and run console again, then >> you can delete the snapshot. Initially, seems to be very slow, >> takes quite a while before 1% shows up >> >> maybe more productive to perform some sanity checks before major >> code changes go to SVN. A bit frustrated ! >> >> --- On *Fri, 11/6/09, Ulrich Moeller /<[email protected] >> <http://us.mc343.mail.yahoo.com/mc/[email protected]>>/* >> wrote: >> >> >> From: Ulrich Moeller <[email protected] >> <http://us.mc343.mail.yahoo.com/mc/[email protected]>> >> Subject: Re: [vbox-dev] VBoxSvc crash when deleting snapshots >> To: [email protected] >> >> <http://us.mc343.mail.yahoo.com/mc/[email protected]> >> Date: Friday, November 6, 2009, 5:01 AM >> >> Thanks for the report. I just fixed this, please check the >> next sync. >> >> Huihong Luo wrote: >> > >> > MediaData::AttachmentList &snapAtts = >> > snapshot->getSnapshotMachine()->mMediaData->mAttachments; >> > AssertBreak(pAttach = findAttachment(snapAtts, replaceHd)); >> > } >> > attachLock.unlock(); <=== CRASH >> > AutoWriteLock attLock(pAttach); >> > pAttach->updateMedium(pHD, false /* aImplicit */); >> > toDiscard.push_back(MediumDiscardRec(pHD, >> > chain, >> > replaceHd, >> > pAttach, >> > snapshotId)); >> > >> > >> >> >> >> VBoxSVC.exe!SessionMachine::deleteSnapshotHandler(SessionMachine::DeleteSnapshotTask >> > & aTask={...}) Line 2201 + 0x14 bytes C++ >> > VBoxSVC.exe!SessionMachine::DeleteSnapshotTask::handler() >> Line 1122 C++ >> > VBoxSVC.exe!Sess5:45 PM >> 11/5/2009ionMachine::taskHandler(RTTHREADINT * >> > __formal=0x028bb868, void * pvUser=0x028c8148) Line 1145 C++ >> > VBoxRT.dll!rtThreadMain(RTTHREADINT * pThread=0x028bb868, >> unsigned int >> > NativeThread=5712, const char * pszThreadName=0x028bb8d0) >> Line 637 + >> > 0xa bytes C++ >> > VBoxRT.dll!rtThreadNativeMain(void * pvArgs=0x028bb868) >> Line 106 + >> > 0xb bytes C++ >> > msvcr80.dll!_callthreadstartex() Line 348 + 0x6 bytes C >> > msvcr80.dll!_threadstartex(void * ptd=0x01eab6b0) Line >> 326 + 0x5 bytes C >> > kernel32.d...@basethreadinitthunk@12 >> > <mailto:kernel32.d...@basethreadinitthunk@12>() + 0x12 bytes >> > ntdll.dll!___rtluserthreadst...@8 >> > <mailto:ntdll.dll!___rtluserthreadst...@8>() + 0x27 bytes >> > ntdll.dll!__rtluserthreadst...@8 >> > <mailto:ntdll.dll!__rtluserthreadst...@8>() + 0x1b bytes >> > >> > >> > >> >> ------------------------------------------------------------------------ >> > >> > _______________________________________________ >> > vbox-dev mailing list >> > [email protected] >> >> <http://us.mc343.mail.yahoo.com/mc/[email protected]> >> > http://vbox.innotek.de/mailman/listinfo/vbox-dev >> >> >> >> _______________________________________________ >> vbox-dev mailing list >> [email protected] >> >> <http://us.mc343.mail.yahoo.com/mc/[email protected]> >> http://vbox.innotek.de/mailman/listinfo/vbox-dev >> >> _______________________________________________ >> vbox-dev mailing list >> [email protected] >> <http://us.mc343.mail.yahoo.com/mc/[email protected]> >> http://vbox.innotek.de/mailman/listinfo/vbox-dev > -- -- Dr. Ulrich Möller, Berlin, Germany Phone: +49 (30) 2345 7072 | Int. x64070 | [email protected] _______________________________________________ vbox-dev mailing list [email protected] http://vbox.innotek.de/mailman/listinfo/vbox-dev
