Frank > Yes, when setting maxlength and tlength to -1, PulseAudio 0.9.21 > will select some sane default values, 4MB for maxlength and 250ms > for tlength. But these default settings are not implemented for > older releases, in particular not for version 0.9.10 I'm using here. > Setting maxlength to -1 is not allowed if buffer_attr != NULL. Therefore > I've changed the values for tlength to 100ms and maxlength to 3/2 of > tlength as it was before. I've not changed your default values for > audio input as I did not test audio input yet.
I remember that bug now, it appears to have been fixed from 0.9.11 on. I had a look at the record metrics again and changed them in this patch to be the same, where the fragsize is the same as the config struct value, and the maxlength is 3/2 that. > Sure, I've just committed the current state of affairs, see > > http://www.virtualbox.org/changeset/25678 Yay. Contributing to VirtualBox has been a nicer experience than most of my dealing with large projects. I have another small patch to submit for though. Changes include the aforementioned changed to record buffer metrics, as well as removal of pulse_ctl() and associated enumeration in favor of using the stream_success_callback for error detection. This does make log output less descriptive though. An issue which still probably needs addressing is the handling of errors. Currently all errors (such as connection termination, or stream read/write failures) are treated fatal and the machine will stop. Perhaps this should be handled so that audio stops but the machine can continue to run? Cheers - Art -- Arthur Taylor [email protected] [email protected]
vbox-pulseaudio-rewrite-2.patch
Description: Binary data
_______________________________________________ vbox-dev mailing list [email protected] http://vbox.innotek.de/mailman/listinfo/vbox-dev
