SVN updated to r36422 and no problems with the USB subset in Ubuntu 10.10.
Looks like you have fixed the issue my friend.

I install from SVN usually the day you release it so I can test it all the way to packing and installing.
Testing on Ubuntu, Debian, openSUSE, Fedora, and Solaris.



On 03/25/2011 05:22 AM, Michael Thayer wrote:
Perry,

I hope that current HEAD will work for you again.  If you give it a try
please let me know!

Regards,

Michael

On Thu, 2011-03-24 at 09:01 -0500, Perry Halbert wrote:
Michael,

It looks like the second patch you sent actually seems to fix the
problem.  I had failed to reverse the first patch before I ran the
second one and it looks like it got confused along with me.  I will
check further today and see what happens.



On 03/23/2011 07:52 PM, Perry Halbert wrote:
Well thinking that it was some left over src code I purged the
build
environment and rebuilt using 1) the latest from SVN and then 2)
with
you latest patch.  Neither seemed to make a difference. I will see
if
I can tweak it some more tomorrow and let you know but I suspect
the
negations are causing the problem,especially since I can put them
back
and all is happy again.  Seems something else is looking for these
removed snippets somewhere and are not at all happy that they are
missing.
Oh happy days, right :-)



On 03/23/2011 04:58 PM, Michael Thayer wrote:
On Wed, 2011-03-23 at 16:52 -0500, Perry Halbert wrote:
Sorry that doesn't get it either.
I read that link a few days ago but remember I had no problems
until
the
changes in 36350 today.
I take it it builds correctly for you this time though.  Did you
check
whether the device nodes are correctly created under /dev/vboxusb
when
you plug in devices?  And you might also check which of the two
entries
which I removed from that structure was the important one.  I
presume it
was
{ "/dev/bus/usb",  true }

Regards,

Michael

On 03/23/2011 04:34 PM, Michael Thayer wrote:
On Wed, 2011-03-23 at 16:15 -0500, Perry Halbert wrote:
Well going back to the present build does not work.  Node is not
created
and and the error returns.
I added the changes that you show in previous reply and get an
error
shown below
Sorry about that!  Here is the correct patch.

By the way, see also [http://www.virtualbox.org/ticket/8502  ].

Regards,

Michael

Index: src/VBox/Main/src-server/linux/USBGetDevices.cpp

===================================================================
--- src/VBox/Main/src-server/linux/USBGetDevices.cpp  (revision
70699)
+++ src/VBox/Main/src-server/linux/USBGetDevices.cpp  (working
copy)
@@ -1442,17 +1442,7 @@
                if (   fHaveInotify
                    &&    !pcBestSysfs
                    &&
RTPathExists(s_aTreeLocations[i].szDevicesRoot))
-            {
-                PUSBDEVICE pDevices;
-
-                pDevices =
getDevicesFromSysfs(s_aTreeLocations[i].szDevicesRoot,
-                                               true);
-                if (pDevices)
-                {
-                    pcBestSysfs =&s_aTreeLocations[i];
-                    deviceListFree(&pDevices);
-                }
-            }
+                pcBestSysfs =&s_aTreeLocations[i];
            }
        if (pcBestUsbfs&&    !fPreferSysfs)
            return pcBestUsbfs;



Reverting and nodes do show up in /dev/vboxusb

This works
static const USBDEVTREELOCATION s_aTreeLocations[] =
{
        { "/proc/bus/usb", false },
        { "/dev/bus/usb",  false },
        { "/dev/vboxusb",  true },
        { "/dev/bus/usb",  true },
};

This does not work
static const USBDEVTREELOCATION s_aTreeLocations[] =
{
        { "/dev/vboxusb",  true },
        { "/proc/bus/usb", false },
};


On 03/23/2011 03:30 PM, Michael Thayer wrote:
On Wed, 2011-03-23 at 15:17 -0500, Perry Halbert wrote:
By additions this time I was talking about the additional
changes
to
the
file.

Give me a bit and I will see what happens.  Takes about 10
minutes
to
get back to a clean build.
If that makes a difference you might try with the following
patch.
Regards,

Michael

Index: src/VBox/Main/src-server/linux/USBGetDevices.cpp

===================================================================
--- src/VBox/Main/src-server/linux/USBGetDevices.cpp  (revision
70699)
+++ src/VBox/Main/src-server/linux/USBGetDevices.cpp  (working
copy)
@@ -1443,15 +1443,8 @@
                     &&     !pcBestSysfs
                     &&
RTPathExists(s_aTreeLocations[i].szDevicesRoot))
                 {
-                PUSBDEVICE pDevices;
-
-                pDevices =
getDevicesFromSysfs(s_aTreeLocations[i].szDevicesRoot,
-                                               true);
-                if (pDevices)
-                {
-                    pcBestSysfs =&s_aTreeLocations[i];
-                    deviceListFree(&pDevices);
-                }
+                pcBestSysfs =&s_aTreeLocations[i];
+                deviceListFree(&pDevices);
                 }
             }
         if (pcBestUsbfs&&     !fPreferSysfs)


On 03/23/2011 03:14 PM, Michael Thayer wrote:
On Wed, 2011-03-23 at 15:06 -0500, Perry Halbert wrote:
Yes it had the directory.  I don't know if it actually
created
it
but
when investigating it was there.

I can rebuild with the additions if you want for me to look
for
anything
specific.
The Additions shouldn't play any part here.  I will give you
another
test though - try stopping all VirtualBox processes, plugging
in
a
USB
device (a node should be created in /dev/vboxusb for it) and
restarting
VirtualBox.

Regards,

Michael

On 03/23/2011 02:58 PM, Michael Thayer wrote:
Hello Perry,

On Wed, 2011-03-23 at 14:52 -0500, Perry Halbert wrote:
Changeset 36350 breaks the USB subset
trunk/src/VBox/Main/src-server/linux/USBGetDevices.cpp
(modified)
(1 diff)
Host Ubuntu 10.10 x86_32
Removing the change fixes it.
Does the directory /dev/vboxusb exist on your system?  Does
creating
it
make a difference if not?

Regards,

Michael
_______________________________________________
vbox-dev mailing list
[email protected]
http://vbox.innotek.de/mailman/listinfo/vbox-dev

Reply via email to