Thank you for the patch François,

Although I didn't go through the patch in fine-detail I had a brief skim through it and noticed a few things that we might want to address:

1. Skip src/Installer/Haiku/* for now as these are Solaris additions and none of that stuff will work on Haiku. For Haiku we'd just want to use a Makefile.kmk and create a .zip with the relevant files and a ".sh" that updates the drivers on a running Haiku system (not sure how to do this explicitly on Haiku as I heard the drivers are loaded with directory node-monitoring). If Haiku has a working and well-established package manager (Synthetic pkgman) already we might want to produce a package in that format.

2. Name the functions with "Haiku" rather than "Hku", eg rtR0SemEventHkuRetain() as rtR0SemEventHaikuRetain() as it's not much longer and we use full-names in other platforms too (rtR0SemEventDarwinRetain)

3. We might want to separate out the VBoxTray and other platform patches from this patch.

4. There are some incorrect copyright headers (memobj-r0drv-haiku.c for instance) which needs to be changed.

And is this patch licensed as MIT?

A patch which doesn't change any other code and contributions fall into "Haiku" subdirectories is more likely to be integrated sooner.

At present I understand the additions are working but it's unclear to me how far the Haiku host support has progressed. Thank you again for your contributions.

Regards,
Ram.



On 04/ 3/11 01:23 PM, François Revol wrote:
Hi,
I already mentioned a preliminary Haiku port.
This patch also includes some guest addition support:
- mouse integration (broken though with some apps),
- clipboard.
It's mostly for the record but comments are welcome.

Linked here as it's quite large:
http://revolf.free.fr/beos/patches/virtualbox-haiku-port-004.diff

François.
_______________________________________________
vbox-dev mailing list
[email protected]
http://vbox.innotek.de/mailman/listinfo/vbox-dev


_______________________________________________
vbox-dev mailing list
[email protected]
http://vbox.innotek.de/mailman/listinfo/vbox-dev

Reply via email to