Hi,
Recently discovered a minor but annoying incorrect key mapping in the
VBoxHeadless VNC code.
Apparently the comma (,) is being mapped to the open-single-quote (`) key
scan code.
I could not find any documentation stating that this was intentional so I
suppose that it is a bug.
Attached is a patch to FramebufferVNC.cpp that fixes the key mapping. The
patch is submitted under the MIT license. The patch is against 3.2.12_OSE
version, however I confirmed the same bug is also present in the most recent
SVN version.
I am submitting the patch here on the mailing list because that seems to be
what I'm supposed to do based on the contributor information up on
virtualbox.org. If this is not OK, just let me know where it should go and
I'll repost to the appropriate place.
Thanks!
Jonathon Moldenhauer
*** FramebufferVNC.cpp.orig Tue Apr 12 00:56:10 2011
--- FramebufferVNC.cpp Tue Apr 12 00:56:51 2011
***************
*** 232,238 ****
static int codes_low[] =
{
//Conversion table for VNC key code range 32-127
! 0x0239, 0x0102, 0x0128, 0x0104, 0x0105, 0x0106, 0x0108, 0x0028, 0x010a, 0x010b, 0x0109, 0x010d, 0x0029, 0x000c, 0x0034, 0x0035, //space, !"#$%&'()*+`-./
0x0b, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0a, //0123456789
0x0127, 0x0027, 0x0133, 0x000d, 0x0134, 0x0135, 0x0103, //:;<=>?@
0x11e, 0x130, 0x12e, 0x120, 0x112, 0x121, 0x122, 0x123, 0x117, 0x124, 0x125, 0x126, 0x132, 0x131, 0x118, 0x119, 0x110, 0x113, 0x11f, 0x114, 0x116, 0x12f, 0x111, 0x12d, 0x115, 0x12c, //A-Z
--- 232,238 ----
static int codes_low[] =
{
//Conversion table for VNC key code range 32-127
! 0x0239, 0x0102, 0x0128, 0x0104, 0x0105, 0x0106, 0x0108, 0x0028, 0x010a, 0x010b, 0x0109, 0x010d, 0x0033, 0x000c, 0x0034, 0x0035, //space, !"#$%&'()*+,-./
0x0b, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0a, //0123456789
0x0127, 0x0027, 0x0133, 0x000d, 0x0134, 0x0135, 0x0103, //:;<=>?@
0x11e, 0x130, 0x12e, 0x120, 0x112, 0x121, 0x122, 0x123, 0x117, 0x124, 0x125, 0x126, 0x132, 0x131, 0x118, 0x119, 0x110, 0x113, 0x11f, 0x114, 0x116, 0x12f, 0x111, 0x12d, 0x115, 0x12c, //A-Z
_______________________________________________
vbox-dev mailing list
[email protected]
http://vbox.innotek.de/mailman/listinfo/vbox-dev
