Hi Virtualbox Devs, Could this patch please be applied before the next maintenance release?
- James On 24/09/2012, at 11:10 AM, James Lucas <[email protected]> wrote: > Hi All, > > Attached is a patch for the websrv-php xml stylesheet. Ian, do you mind > verifying and then could the vbox developers please apply? > > This patch takes into account the safearray definition when emitting a set > function for attributes in the php libs. The two affected attributes are > "groups" in IMachine and "environment" in IGuestSession. If you want to > generate your own modified library you can either change the > vboxServiceWrappers.php file with the following diff or run `xsltproc > websrv-php.xsl VirtualBox.xidl` (VirtualBox.xidl from the SDK) > > @@ -2173,7 +2173,7 @@ > public function setGroups($value) { > $request = new stdClass(); > $request->_this = $this->handle; > - if (is_null($value) || is_scalar($value)) { > + if (is_array($value) || is_null($value) || is_scalar($value)) { > $request->groups = $value; > } > else > @@ -4991,7 +4991,7 @@ > public function setEnvironment($value) { > $request = new stdClass(); > $request->_this = $this->handle; > - if (is_null($value) || is_scalar($value)) { > + if (is_array($value) || is_null($value) || is_scalar($value)) { > $request->environment = $value; > } > else > > As always this is licensed under MIT (and I have signed a contributor > agreement with Oracle) > > - James > > On 23/09/2012, at 8:13 AM, Ian Moore <[email protected]> wrote: > >> Hello, >> >> Line 2176 in vboxServiceWrappers.php needs to be changed to: >> >> if (is_null($value) || is_scalar($value) || is_array($value)) { >> >> In order to be able to correctly set VM groups. It does not currently >> account for an array type argument - which is what the setGroups function >> should be passed. >> >> On a completely unrelated note, it appears that the disabled version of the >> exit_16px.png icon is not anywhere in SVN. It can be seen in the VirtualBox >> frontend in the VM context menu of the chooser when a VM is not running. >> Would it be possible to obtain a copy of this icon please? >> >> Regards, >> Ian >> _______________________________________________ >> vbox-dev mailing list >> [email protected] >> https://www.virtualbox.org/mailman/listinfo/vbox-dev > > > > > > -- > UTS CRICOS Provider Code: 00099F > DISCLAIMER: This email message and an > y accompanying attachments may contain > confidential information. If you are > not the intended recipient, do not > read, use, disseminate, distribute or co > py this message or attachments. If > you have received this message in error, > please notify the sender > immediately and delete this message. Any views exp > ressed in this message > are those of the individual sender, except where the > sender expressly, and > with authority, states them to be the views the Univer > sity of Technology, > Sydney. Before opening any attachments, please check the > m for viruses and > defects. > > > <websrv-php.diff>_______________________________________________ > vbox-dev mailing list > [email protected] > https://www.virtualbox.org/mailman/listinfo/vbox-dev _______________________________________________ vbox-dev mailing list [email protected] https://www.virtualbox.org/mailman/listinfo/vbox-dev
