On Ter, 2012-10-09 at 23:24 +0200, Michael Thayer wrote: > Hello Sérgio, > > On 10/02/2012 04:58 PM, Sérgio Basto wrote: > > On Sex, 2012-09-28 at 11:19 +0200, Michael Thayer wrote: > >> On 09/27/2012 10:54 PM, Sérgio Basto wrote: > >> [...] > >>> as a little side note, we have in > >>> VirtualBox-4.2.0/src/VBox/Additions/x11/vboxvideo/Makefile.kmk : > >>> > >>> vboxvideo_70_DEFS := IN_MODULE XORG_7X RENDER=1 IN_RT_STATIC > >>> vboxvideo_13_DEFS := $(vboxvideo_70_DEFS) VBOXVIDEO_13 > >>> vboxvideo_15_DEFS := $(vboxvideo_13_DEFS) VBOX_DRI NO_ANSIC PCIACCESS > >>> XSERVER_LIBPCIACCESS > >>> > >>> vboxvideo_drv_70_DEFS = $(vboxvideo_70_DEFS) > >>> XORG_VERSION_CURRENT=700000000 > >>> > >>> vboxvideo_drv_13_DEFS := $(vboxvideo_13_DEFS) > >>> XORG_VERSION_CURRENT=100300000 > >>> > >>> > >>> what I mean when I want know what DEFS for vboxvideo_drv_113, I got to > >>> follow all attributions ... and can't comment any ... > [...] > > Hi, > > thanks for reply , sorry I'm little busy here . > > Generally I agree with you , I'm just pointing that you could avoid chains > > like > > > > a = something > > b = a > > c = b > > d = c > > > > when you may do : > > a = something > > b = a > > c = a > > d = a > Since those definitions are all next to each other anyway it is surely > not too bad! In any case, I have applied the patch I posted so that you > can build with VBOX_USE_SYSTEM_XORG_HEADERS=1 set in future to only > build the X.Org drivers against the installed system headers.
OK, this is a minor issue and just one advise (avoid chains) . About the patch, once in public svn , let me know what commits are ? and all others that change .kmk(s) related with it. Thanks, -- Sérgio M. B. _______________________________________________ vbox-dev mailing list [email protected] https://www.virtualbox.org/mailman/listinfo/vbox-dev
