Hello Michel, On 11/02/2012 04:29 AM, Michel Alexandre Salim wrote: [...] > On 30/10/2012 22:00, Michael Thayer wrote: [...] >> Does changeset 43768[1] look right to you? [...] > The changes look good, but - having not tested it yet or seen the > full .spec file after the change - you might need to add runtime > dependencies on more packages that provide /usr/share/icons/hicolor > and /usr/share/mime: > > $ rpm -qf /usr/share/mime /usr/share/icons/hicolor | grep -v fedora > shared-mime-info-1.0-5.fc18.x86_64 > hicolor-icon-theme-0.12-5.fc18.noarch
I wonder whether this is necessary (I have to say that I am not the person who wrote the RPM spec file)? My thinking is as follows: since those directories are created (but their ownership not claimed) by our spec file, they - and the files in them - should be created when the RPM is installed if they do not already exist, without causing problems if the packages claiming ownership are installed later. However, the only situation in which shared-mime-info and hicolor-icon-theme are likely not to be installed is if no complete desktop environment is installed. In this case the files we install into those directories are harmless but useless, and as long as there isn't a consumer for them, pulling in shared-mime-info and hicolor-icon-theme will not make them any more useful, so we don't really gain anything from depending on those packages. What is more, if we did try to pull them in we would have to check whether the package names are the same in all RPM-based distributions which we support and if not hack our spec file to do the right thing. Regards, Michael -- ORACLE Deutschland B.V. & Co. KG Michael Thayer Werkstrasse 24 VirtualBox engineering 71384 Weinstadt, Germany mailto:[email protected] Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Geschäftsführer: Jürgen Kunz Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher _______________________________________________ vbox-dev mailing list [email protected] https://www.virtualbox.org/mailman/listinfo/vbox-dev
