On 06/27/2016 10:06 AM, Frank Mehnert wrote:
Peter,
On Monday 27 June 2016 16:35:26 Hans-Peter Jansen wrote:
just in case, somebody stumbles upon some similar build issue:
/home/abuild/rpmbuild/BUILD/VirtualBox-5.0.22/kmk_sed "s/<NL>/\n/g" --output
/home/abuild/rpmbuild/BUILD/VirtualBox-5.0.22/out/linux.amd64/release/obj/V
BoxDD/vboxssdt-cpuhotplug.hex.pre1
/home/abuild/rpmbuild/BUILD/VirtualBox-5.0.22/out/linux.amd64/release/obj/V
BoxDD/vboxssdt-cpuhotplug.hex.pre
/home/abuild/rpmbuild/BUILD/VirtualBox-5.0.22/kmk_sed: line 7: NL: file or
directory not found
it might be fixed using the attached patch, which is MIT licensed just in
case...
I wonder, how this could creep into the distribution, but it could also be
related to the openSUSE build, that I based my build upon (but the applied
patches doesn't appear to be guilty, AFAICS).
your patch for adding '-e' to the $(SED) command is not required here
but it's IMO more correct so I will add it to the repository.
openSUSE had a 5.0.18 in the stores, that is carrying a vbox-4.7.patch
around. After merging with 5.0.22, just one hunk was left, and that's
looking rather fishy:
Index: b/src/VBox/HostDrivers/VBoxNetAdp/linux/VBoxNetAdp-linux.c
===================================================================
--- a/src/VBox/HostDrivers/VBoxNetAdp/linux/VBoxNetAdp-linux.c
+++ b/src/VBox/HostDrivers/VBoxNetAdp/linux/VBoxNetAdp-linux.c
@@ -152,8 +152,10 @@ static int vboxNetAdpLinuxXmit(struct sk
/* Update the stats. */
pPriv->Stats.tx_packets++;
pPriv->Stats.tx_bytes += pSkb->len;
-#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 31)
/* Update transmission time stamp. */
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 7, 0)
+ netif_trans_update(pNetDev);
+#else
pNetDev->trans_start = jiffies;
#endif
/* Nothing else to do, just free the sk_buff. */
Since this is not a transparent patch for kernel versions below 4.7, I
refrained from applying this at all. It bears the question though, how this
is done correctly, e.g. does 4.7 and above needs the netif_trans_update
call, 2.6.31 and below the jiffies tagging, and what to do with the kernel
versions in between.
In case, you want to peak into the build, here it is:
https://build.opensuse.org/package/show/home:frispete:Kernel-stable/virtual
box
The openSUSE patch is not necessary. Since 2.6.31 there is no need to update
trans_start as it is done by dev_hard_start_xmit by calling the
txq_trans_update upon device xmit callback exit.
The reason to build this package myself is due to suffering from an issue
with 5.0.18 and a bridged nic setup, that is flooding my logs with:
VBoxNetFlt: Failed to allocate packet buffer, dropping the packet.
Last message 'VBoxNetFlt: Failed t' repeated 196 times, suppressed by
syslog-ng
That's produced from a w2k8R2 VM on a Linux 4.2.25 host. The VM seems to
suffer under high host load. Let's see, how 5.0.22 behaves in this respect.
In case, this rings a bell for you, let me know.
Sorry, doesn't ring a bell.
In the "official" openSUSE repo, that patch is no longer applied for 5.0.22 as
it was only needed for earlier versions of VB.
Larry
_______________________________________________
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev
